[FFmpeg-cvslog] udp: Properly check for invalid sockets

Martin Storsjö git at videolan.org
Wed Jun 20 21:25:29 CEST 2012


ffmpeg | branch: master | Martin Storsjö <martin at martin.st> | Tue Jun 19 17:59:57 2012 +0300| [042b272a4ad849c86d63ff1532beebc308d0ece9] | committer: Martin Storsjö

udp: Properly check for invalid sockets

If stdin has been closed, 0 is a valid socket descriptor.

Signed-off-by: Martin Storsjö <martin at martin.st>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=042b272a4ad849c86d63ff1532beebc308d0ece9
---

 libavformat/udp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/udp.c b/libavformat/udp.c
index 77ab8c2..0eaed1b 100644
--- a/libavformat/udp.c
+++ b/libavformat/udp.c
@@ -200,7 +200,7 @@ static int udp_socket_create(UDPContext *s, struct sockaddr_storage *addr,
         goto fail;
     for (res = res0; res; res=res->ai_next) {
         udp_fd = socket(res->ai_family, SOCK_DGRAM, 0);
-        if (udp_fd > 0) break;
+        if (udp_fd != -1) break;
         log_net_error(NULL, AV_LOG_ERROR, "socket");
     }
 



More information about the ffmpeg-cvslog mailing list