[FFmpeg-cvslog] vf_overlay: prevent premature freeing of cur_buf

Michael Niedermayer michaelni at gmx.at
Fri Jul 27 00:02:24 CEST 2012


On Thu, Jul 26, 2012 at 11:17:42PM +0200, Nicolas George wrote:
> Le nonidi 9 thermidor, an CCXX, Michael Niedermayer a écrit :
> > @@ -238,6 +238,7 @@ static int start_frame_overlay(AVFilterLink *inlink, AVFilterBufferRef *inpicref
> >      AVFilterContext *ctx = inlink->dst;
> >      OverlayContext *over = ctx->priv;
> >  
> > +    inlink->cur_buf  = NULL;
> >      over->overpicref = inpicref;
> >      over->overpicref->pts = av_rescale_q(inpicref->pts, ctx->inputs[OVERLAY]->time_base,
> >                                           ctx->outputs[0]->time_base);
> 
> They made the same mistake I made in 9c1d649 (and that the patch I sent a
> few hours ago fixes). It's rather tasteless to put your name on a bogus
> commit just because it was cherry-picked from a completely different, good,
> commit.

I have the suspicion noone will understand this paragraph.
I myself had to read it twice. First time i thought iam being
accused of having put my name on something. But that being a commit
by luca the correct interpretation must be that its tasteless from
luca to put my name on a buggy line from a good commit.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20120727/17e1eb98/attachment.asc>


More information about the ffmpeg-cvslog mailing list