[FFmpeg-cvslog] imgconvert: avoid undefined left shift in avcodec_find_best_pix_fmt
Janne Grunau
git at videolan.org
Sun Jul 15 01:34:59 CEST 2012
ffmpeg | branch: master | Janne Grunau <janne-libav at jannau.net> | Mon Jul 2 10:46:39 2012 +0200| [39bb27bf79bc4c2d8beaed637a14176264cb1916] | committer: Janne Grunau
imgconvert: avoid undefined left shift in avcodec_find_best_pix_fmt
CC: libav-stable at libav.org
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=39bb27bf79bc4c2d8beaed637a14176264cb1916
---
libavcodec/imgconvert.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/imgconvert.c b/libavcodec/imgconvert.c
index 90c9b7b..7a6102e 100644
--- a/libavcodec/imgconvert.c
+++ b/libavcodec/imgconvert.c
@@ -599,7 +599,8 @@ static enum PixelFormat avcodec_find_best_pix_fmt1(int64_t pix_fmt_mask,
/* find exact color match with smallest size */
dst_pix_fmt = PIX_FMT_NONE;
min_dist = 0x7fffffff;
- for(i = 0;i < PIX_FMT_NB; i++) {
+ /* test only the first 64 pixel formats to avoid undefined behaviour */
+ for (i = 0; i < 64; i++) {
if (pix_fmt_mask & (1ULL << i)) {
loss = avcodec_get_pix_fmt_loss(i, src_pix_fmt, has_alpha) & loss_mask;
if (loss == 0) {
More information about the ffmpeg-cvslog
mailing list