[FFmpeg-cvslog] Revert "Fix channel layout for some stereo flac files."

Nicolas George nicolas.george at normalesup.org
Sat Feb 25 14:50:42 CET 2012


Le sextidi 6 ventôse, an CCXX, Michael Niedermayer a écrit :
> -        if (fi->ch_mode <= 5)
> -            avctx->channel_layout = ff_vorbis_channel_layouts[fi->ch_mode];

This one I see was not right: Vorbis and FLAC use different channels order
and layouts.

But this one:

> Revert "Fix channel layout for some stereo flac files."
> This reverts commit d2ee3c913d6fec3cb8c0c1b67347007c7cd604e1.

>      } else if (fi->ch_mode <= FLAC_CHMODE_MID_SIDE) {
>          fi->channels = 2;
> -        avctx->channel_layout = AV_CH_LAYOUT_STEREO;

... looks like it was right: why would we have 2 channels and no stereo?

Can you explain why you reverted?

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20120225/2afb9a00/attachment.asc>


More information about the ffmpeg-cvslog mailing list