[FFmpeg-cvslog] lavfi/alphaextract: drop cur_linesize = out_linesize branch in draw_slice()

Stefano Sabatini git at videolan.org
Fri Dec 7 19:11:30 CET 2012


ffmpeg | branch: master | Stefano Sabatini <stefasab at gmail.com> | Fri Dec  7 18:36:58 2012 +0100| [1f467220cfd1664782b1fe210bbc9342ad460fd2] | committer: Stefano Sabatini

lavfi/alphaextract: drop cur_linesize = out_linesize branch in draw_slice()

The code causes uninitialized data copy, and may be actually slower than
a loop over each line in case the padding is big.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=1f467220cfd1664782b1fe210bbc9342ad460fd2
---

 libavfilter/vf_alphaextract.c |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/libavfilter/vf_alphaextract.c b/libavfilter/vf_alphaextract.c
index 35402f6..e779c98 100644
--- a/libavfilter/vf_alphaextract.c
+++ b/libavfilter/vf_alphaextract.c
@@ -77,11 +77,6 @@ static int draw_slice(AVFilterLink *inlink, int y0, int h, int slice_dir)
                 pin += 4;
             }
         }
-    } else if (cur_buf->linesize[A] == out_buf->linesize[Y]) {
-        const int linesize = cur_buf->linesize[A];
-        memcpy(out_buf->data[Y] + y0 * linesize,
-               cur_buf->data[A] + y0 * linesize,
-               linesize * h);
     } else {
         const int linesize = FFMIN(out_buf->linesize[Y], cur_buf->linesize[A]);
         int y;



More information about the ffmpeg-cvslog mailing list