[FFmpeg-cvslog] Add CPiA video decoder

[Michael Niedermayer]

On Fri, Aug 31, 2012 at 06:22:27PM +0200, Reimar Döffinger wrote:
> Sorry for being late in commenting.
> 
> > +    // Get buffer filled with previous frame
> > +    if ((ret = avctx->reget_buffer(avctx, frame)) < 0) {
> > +        av_log(avctx, AV_LOG_ERROR, "reget_buffer() failed!\n");
> > +        return ret;
> > +    }
> [...]
> > +    if (header[28] == NOT_COMPRESSED) {
> > +        frame->pict_type = AV_PICTURE_TYPE_I;
> > +        frame->key_frame = 1;
> > +    } else {
> > +        frame->pict_type = AV_PICTURE_TYPE_P;
> > +        frame->key_frame = 0;
> > +    }
> 
> Shouldn't this be set before reget_buffer?
> Or rather better, reget_buffer moved after it, so as to avoid
> getting a buffer and right after bailing out due to header errors,
> which is at least a bit ugly.

I think Stephan is not subscribed to this mailing list

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20120831/74e30882/attachment.asc>