[FFmpeg-cvslog] mov: zero sc->pb in mov_read_close()

Michael Niedermayer git at videolan.org
Fri Apr 13 12:27:09 CEST 2012


ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Fri Apr 13 12:09:32 2012 +0200| [84d74610f9d27077e9260b544ae52d732e92e5de] | committer: Michael Niedermayer

mov: zero sc->pb in mov_read_close()

Its bad to free things without zeroing them.
This fixes a potential issue when mov_read_close() would be called twice.

Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=84d74610f9d27077e9260b544ae52d732e92e5de
---

 libavformat/mov.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/libavformat/mov.c b/libavformat/mov.c
index 5b81ba8..234c1f5 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -2782,6 +2782,7 @@ static int mov_read_close(AVFormatContext *s)
         av_freep(&sc->drefs);
         if (sc->pb && sc->pb != s->pb)
             avio_close(sc->pb);
+        sc->pb = NULL;
         av_freep(&sc->chunk_offsets);
         av_freep(&sc->keyframes);
         av_freep(&sc->sample_sizes);



More information about the ffmpeg-cvslog mailing list