[FFmpeg-cvslog] Add .bit (de)muxer

Michael Niedermayer michaelni at gmx.at
Sat Sep 24 22:25:50 CEST 2011


On Sat, Sep 24, 2011 at 10:18:42PM +0200, Clément Bœsch wrote:
> On Sat, Sep 24, 2011 at 10:12:20PM +0200, Vladimir Voroshilov wrote:
> > ffmpeg | branch: master | Vladimir Voroshilov <voroshil at gmail.com> | Sat Sep 24 22:08:16 2011 +0200| [0f2297a9b958b8598b17f139e7ec2d7e593a0a7c] | committer: Michael Niedermayer
> > 
> > Add .bit (de)muxer
> > 
> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=0f2297a9b958b8598b17f139e7ec2d7e593a0a7c
> > ---
> > 
> >  libavformat/bit.c |  150 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 150 insertions(+), 0 deletions(-)
> > 
> > diff --git a/libavformat/bit.c b/libavformat/bit.c
> > new file mode 100644
> > index 0000000..ad55a55
> > --- /dev/null
> > +++ b/libavformat/bit.c
> > @@ -0,0 +1,150 @@
> > +#include "avformat.h"
> > +#include "libavcodec/get_bits.h"
> > +#include "libavcodec/put_bits.h"
> > +
> 
> Isn't this missing the licence header?

indeed, vladimir are you ok if i add a LGPL header with your name ?



> 
> [...]
> > +
> > +AVInputFormat ff_bit_demuxer = {
> > +    "bit",
> > +    "G.729 BIT file format",
> > +    0,
> > +    probe,
> > +    read_header,
> > +    read_packet,
> > +    .extensions = "bit"
> > +};
> > +
> 
> Shouldn't we use struct initializers here?

patch/commit welcome

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20110924/9f027edb/attachment.asc>


More information about the ffmpeg-cvslog mailing list