[FFmpeg-cvslog] apedec: use unsigned int for 'nblocks' and make sure that it' s within int range

Justin Ruggles git at videolan.org
Sat Oct 29 02:31:37 CEST 2011


ffmpeg | branch: master | Justin Ruggles <justin.ruggles at gmail.com> | Tue Oct 11 13:17:44 2011 -0400| [2cab5784892c6ae47feb5f1a97445946b3404ac0] | committer: Justin Ruggles

apedec: use unsigned int for 'nblocks' and make sure that it's within int range

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=2cab5784892c6ae47feb5f1a97445946b3404ac0
---

 libavcodec/apedec.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c
index a741c7d..f6ec470 100644
--- a/libavcodec/apedec.c
+++ b/libavcodec/apedec.c
@@ -812,7 +812,7 @@ static int ape_decode_frame(AVCodecContext *avctx,
     int buf_size = avpkt->size;
     APEContext *s = avctx->priv_data;
     int16_t *samples = data;
-    int nblocks;
+    uint32_t nblocks;
     int i, n;
     int blockstodecode;
     int bytes_used;
@@ -843,9 +843,9 @@ static int ape_decode_frame(AVCodecContext *avctx,
 
         s->currentframeblocks = nblocks;
         buf += 4;
-        if (nblocks <= 0) {
-            *data_size = 0;
-            return buf_size;
+        if (!nblocks || nblocks > INT_MAX) {
+            av_log(avctx, AV_LOG_ERROR, "Invalid sample count: %u.\n", nblocks);
+            return AVERROR_INVALIDDATA;
         }
         s->samples = nblocks;
 



More information about the ffmpeg-cvslog mailing list