[FFmpeg-cvslog] Move av_tempfile() into libavutil, it is a generically usefull thing and its small.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Oct 16 22:28:33 CEST 2011


On 16 Oct 2011, at 22:16, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sun, Oct 16, 2011 at 09:42:12PM +0200, Reimar Döffinger wrote:
>> On Sun, Oct 16, 2011 at 09:35:26PM +0200, Michael Niedermayer wrote:
>>> On Sun, Oct 16, 2011 at 09:22:11PM +0200, Reimar Döffinger wrote:
>>>> On Sun, Oct 16, 2011 at 05:21:22PM +0200, Michael Niedermayer wrote:
>>>>> -    fd = open(*filename, O_RDWR | O_BINARY | O_CREAT, 0444);
>>>> 
>>>> Adding O_EXCL should increase security here.
>>>> Seems supported at least on Linux and Windows.
>>>> Might fail compilation on some systems though.
>>> 
>>> fixed locally
>> 
>> Oh, and did you fix the 0444 mode? That seems both like
>> a bad idea and mismatches mkstemp behaviour.
> 
> fixed locally, anything else that needs fixing?

Nothing beyond me still having a really bad feeling about this code for now at least.
> 


More information about the ffmpeg-cvslog mailing list