[FFmpeg-cvslog] smacker: check buffer size before reading output size

Justin Ruggles git at videolan.org
Wed Oct 12 05:51:14 CEST 2011


ffmpeg | branch: master | Justin Ruggles <justin.ruggles at gmail.com> | Wed Sep 21 11:42:55 2011 -0400| [cf044f8bff0d28dbc34492f18b0d18b3ba8bad9d] | committer: Justin Ruggles

smacker: check buffer size before reading output size

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=cf044f8bff0d28dbc34492f18b0d18b3ba8bad9d
---

 libavcodec/smacker.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c
index f3dec7f..20ddc15 100644
--- a/libavcodec/smacker.c
+++ b/libavcodec/smacker.c
@@ -586,6 +586,11 @@ static int smka_decode_frame(AVCodecContext *avctx, void *data, int *data_size,
     int bits, stereo;
     int pred[2] = {0, 0};
 
+    if (buf_size <= 4) {
+        av_log(avctx, AV_LOG_ERROR, "packet is too small\n");
+        return AVERROR(EINVAL);
+    }
+
     unp_size = AV_RL32(buf);
 
     init_get_bits(&gb, buf + 4, (buf_size - 4) * 8);



More information about the ffmpeg-cvslog mailing list