[FFmpeg-cvslog] lavf: fix null pointer dereference in rdt

[Michael Niedermayer]

On Fri, Nov 04, 2011 at 04:43:57PM +0100, Reimar Döffinger wrote:
> On Thu, Nov 03, 2011 at 10:50:18PM +0100, Michael Niedermayer wrote:
> > ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Thu Nov  3 22:38:10 2011 +0100| [bb99ae3ae924c942a634bec7711ec7ee11c38eb9] | committer: Michael Niedermayer
> > 
> > lavf: fix null pointer dereference in rdt
> > 
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > 
> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=bb99ae3ae924c942a634bec7711ec7ee11c38eb9
> > ---
> > 
> >  libavformat/utils.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/libavformat/utils.c b/libavformat/utils.c
> > index 855992e..4399176 100644
> > --- a/libavformat/utils.c
> > +++ b/libavformat/utils.c
> > @@ -607,6 +607,9 @@ static int init_input(AVFormatContext *s, const char *filename)
> >      int ret;
> >      AVProbeData pd = {filename, NULL, 0};
> >  
> > +    if(s->iformat && !strlen(filename))
> > +        return 0;
> 
> How can a 0 length string cause a NULL dereference?

function failing, another returning NULL and that being dereferenced

Its a regression caused by
commit 603b8bc2a109978c8499b06d2556f1433306eca7
Author: Anton Khirnov <anton at khirnov.net>
Date:   Sat Jun 4 17:36:30 2011 +0200

    Deprecate av_open_input_* and remove their uses.

    Deprecate the last remaining member of AVFormatParameters.
-------------------------------------------------



> Also, there is no rdt probe function, so do you mean rtsp?

 try rtsp://157.242.136.235:554/classes/f2010/rv-aclu-prop192010-10-14RCa.rm?cloakport=80,554
 the crash happens in rdt.c

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20111104/f4325d1e/attachment.asc>