[FFmpeg-cvslog] dca: fix signed overflow in shift

Mans Rullgard git at videolan.org
Fri Nov 4 13:22:16 CET 2011


ffmpeg | branch: release/0.8 | Mans Rullgard <mans at mansr.com> | Sat Oct  8 13:49:42 2011 +0100| [37ce6ba425d70718b646ba49ec23761abd511d9e] | committer: Michael Niedermayer

dca: fix signed overflow in shift

Signed-off-by: Mans Rullgard <mans at mansr.com>
(cherry picked from commit 559c244d42be7a02c23976216b47fd63b80d6c7f)

Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=37ce6ba425d70718b646ba49ec23761abd511d9e
---

 libavcodec/dca.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/libavcodec/dca.c b/libavcodec/dca.c
index 69df8f4..24153eb 100644
--- a/libavcodec/dca.c
+++ b/libavcodec/dca.c
@@ -905,7 +905,8 @@ static void qmf_32_subbands(DCAContext * s, int chans,
     for (subindex = 0; subindex < 8; subindex++) {
         /* Load in one sample from each subband and clear inactive subbands */
         for (i = 0; i < sb_act; i++){
-            uint32_t v = AV_RN32A(&samples_in[i][subindex]) ^ ((i-1)&2)<<30;
+            unsigned sign = (i - 1) & 2;
+            uint32_t v = AV_RN32A(&samples_in[i][subindex]) ^ sign << 30;
             AV_WN32A(&s->raXin[i], v);
         }
 



More information about the ffmpeg-cvslog mailing list