[FFmpeg-cvslog] sws: replace all long with int.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun May 29 10:47:28 CEST 2011


On 29 May 2011, at 03:46, git at videolan.org (Anton Khirnov) wrote:
> ffmpeg | branch: master | Anton Khirnov <anton at khirnov.net> | Thu May 26 18:57:26 2011 +0200| [b8e893399ff8755721dc117695ec5ff183c1e07b] | committer: Ronald S. Bultje
> 
> sws: replace all long with int.
> 
> Signed-off-by: Ronald S. Bultje <rsbultje at gmail.com>
> 
> diff --git a/libswscale/ppc/swscale_altivec_template.c b/libswscale/ppc/swscale_altivec_template.c
> index eee7bdd..21e3b4e 100644
> --- a/libswscale/ppc/swscale_altivec_template.c
> +++ b/libswscale/ppc/swscale_altivec_template.c
> @@ -29,13 +29,13 @@ altivec_packIntArrayToCharArray(int *val, uint8_t* dest, int dstW)
>     register int i;
>     vector unsigned int altivec_vectorShiftInt19 =
>         vec_add(vec_splat_u32(10), vec_splat_u32(9));
> -    if ((unsigned long)dest % 16) {
> +    if ((unsigned int)dest % 16) {
>         /* badly aligned store, we force store alignment */
>         /* and will handle load misalignment on val w/ vec_perm */
>         vector unsigned char perm1;
>         vector signed int v1;
>         for (i = 0 ; (i < dstW) &&
> -            (((unsigned long)dest + i) % 16) ; i++) {
> +            (((unsigned int)dest + i) % 16) ; i++) {

Did someone actually look at this before committing? This will almost certainly cause a warning on PPC64. uintptr_t would be the right type here for example.


More information about the ffmpeg-cvslog mailing list