[FFmpeg-cvslog] vsrc_buffer: simplify av_vsrc_buffer_add_frame*() interface

[Stefano Sabatini]

On date Friday 2011-05-13 20:37:13 +0200, Michael Niedermayer wrote:
> On Fri, May 13, 2011 at 07:07:27PM +0200, Stefano Sabatini wrote:
> > On date Friday 2011-05-13 16:37:05 +0000, Carl Eugen Hoyos wrote:
> > > Stefano Sabatini <git <at> videolan.org> writes:
> > > 
> > > > ffmpeg | branch: master | Stefano Sabatini | Mon May  2 09:52:11 2011
> > > > +0200| [64c06615d2b99fb9f4ffd6226d0e5787b44a41e2] | committer: Stefano Sabatini
> > > > 
> > > > vsrc_buffer: simplify av_vsrc_buffer_add_frame*() interface
> > > 
> > > This broke multi-threaded (H-264) decoding, ticket 197.
> > 
> > Check attached, untested but now I have no time and I'm not sure I can
> > understand which is the correct way to deal with pkt_dts/pts in case
> > of multithreading.
> 
> I think this stuff should be in avcodec_default_get_buffer() (too)

I believe it is at least partially already done there (with exception
for the SAR?).

Michael can you say which is the right way to tackle the problem?

Should:
picture->pkt_dts= avpkt->dts;
picture->pkt_pos= avpkt->pos;

be set only if threads are disabled?

The first line was set in:

commit b38f008ea64cc5c0087fc9804569338ef005897c
Author: Alexander Strange <astrange at ithinksw.com>
Date:   Mon Feb 7 21:15:44 2011 -0500

    Frame-based multithreading framework using pthreads
    
    See doc/multithreading.txt for details on use in codecs.
    
    Signed-off-by: Ronald S. Bultje <rsbultje at gmail.com>


the second was added by me as I added the pkt_pos field.

Is there some way to enable threading in fate? 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavc-fix-AVFrame-properties-setting-in-case-of-multi.patch
Type: text/x-diff
Size: 1201 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20110513/a685bfab/attachment.bin>