[FFmpeg-cvslog] Chronomaster DFA decoder

Michael Niedermayer michaelni at gmx.at
Wed Mar 30 12:11:02 CEST 2011


On Tue, Mar 29, 2011 at 07:45:27AM +0200, Reimar Döffinger wrote:
> On 29 Mar 2011, at 03:09, git at videolan.org (Kostya Shishkov) wrote:
> > FFmpeg | branch: master | Kostya Shishkov <kostya.shishkov at gmail.com> | Tue Mar 15 09:37:48 2011 +0100| [42315dabce376fd7085e2a1bbab4d230d3d2ccd8] | committer: Anton Khirnov
> > 
> > Chronomaster DFA decoder
> 
> I strongly recommend to disable this.
> This is full of incorrectly done security checks where either overflow is not even considered at all or gcc may optimise away a critical check because in accordance with the C standard it assumes pointer arithmetic will not overflow.

If you think there are still issues left after your commit then iam
of course ok with disabling this decoder

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20110330/7f4225b1/attachment.asc>


More information about the ffmpeg-cvslog mailing list