[FFmpeg-cvslog] reverts parts of commit de11ee906ed232157392924735c18ab7d8522ccb. The author of this patch has a poor understanding of the code

[Michael Niedermayer]

On Fri, Mar 18, 2011 at 10:04:50PM +0100, Maxim wrote:
> Dominik 'Rathann' Mierzejewski schrieb:
> > On Friday, 18 March 2011 at 19:44, Stefano Sabatini wrote:
> >   
> >> On date Friday 2011-03-18 18:13:35 +0100, Michael Niedermayer wrote:
> >>     
> >>> ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Fri Mar 18 13:16:14 2011 +0100| [133055c5e47b047b0806ccdeb42b82e418bd5dfa] | committer: Michael Niedermayer
> >>>
> >>> reverts parts of commit de11ee906ed232157392924735c18ab7d8522ccb. The author of this patch has a poor understanding of the code
> >>>       
> >> I'd appreciate it you would avoid inflammatory comments.
> >>     
> >
> > Yes, it'd be better to say why you think the change was wrong technically.
> >   
> 
> +1.

i guess i could have said it politer
removing that:
      * This may be undefined (AV_NOPTS_VALUE).
+     * @note The ASF header does NOT contain a correct start_time the ASF
+     * demuxer must NOT set this.
      */

is wrong
why?
well, what can i say except that the value simply is not the start time in
some files. But thats written in that comment already.
New team removing that and changeing the code as if things where different
is simply adding a bug



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20110318/5a0ac803/attachment-0001.asc>