[FFmpeg-cvslog] h264 - correct the check for invalid long term frame index in MMCO decode

[Jeff Downs]

ffmpeg | branch: master | Jeff Downs <heydowns at somuchpressure.net> | Tue Jul  5 14:21:54 2011 -0400| [e80e2d5ba1d8c699fa1cf0c329feb6e237362505] | committer: Jeff Downs

h264 - correct the check for invalid long term frame index in MMCO decode

The current checks on MMCO parameters prohibits a "max long term frame index
plus 1" of 16 (frame idx of 15) for the "set max long term frame index" MMCO.
Fix this off-by-one error to allow the full range of legal values.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=e80e2d5ba1d8c699fa1cf0c329feb6e237362505
---

 libavcodec/h264_refs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libavcodec/h264_refs.c b/libavcodec/h264_refs.c
index 2c95253..6794bf3 100644
--- a/libavcodec/h264_refs.c
+++ b/libavcodec/h264_refs.c
@@ -680,7 +680,7 @@ int ff_h264_decode_ref_pic_marking(H264Context *h, GetBitContext *gb){
                 }
                 if(opcode==MMCO_SHORT2LONG || opcode==MMCO_LONG2UNUSED || opcode==MMCO_LONG || opcode==MMCO_SET_MAX_LONG){
                     unsigned int long_arg= get_ue_golomb_31(gb);
-                    if(long_arg >= 32 || (long_arg >= 16 && !(opcode == MMCO_LONG2UNUSED && FIELD_PICTURE))){
+                    if(long_arg >= 32 || (long_arg >= 16 && !(opcode == MMCO_SET_MAX_LONG && long_arg == 16) && !(opcode == MMCO_LONG2UNUSED && FIELD_PICTURE))){
                         av_log(h->s.avctx, AV_LOG_ERROR, "illegal long ref in memory management control operation %d\n", opcode);
                         return -1;
                     }