[FFmpeg-cvslog] vf_mp: do not add duplicated pixel formats.
Clément Bœsch
git at videolan.org
Wed Jul 27 12:49:34 CEST 2011
ffmpeg | branch: release/0.7 | Clément Bœsch <clement.boesch at smartjog.com> | Wed Jun 22 10:33:01 2011 +0200| [680e47364386038c5039345ef2d9fe6947191a12] | committer: Michael Niedermayer
vf_mp: do not add duplicated pixel formats.
This avoid a crash with in avfilter_merge_formats() in case one of the
filter formats list has multiple time the same entry.
Thanks to Mina Nagy Zaki for helping figuring out the issue.
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=680e47364386038c5039345ef2d9fe6947191a12
---
libavfilter/vf_mp.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/libavfilter/vf_mp.c b/libavfilter/vf_mp.c
index 36616b9..9e413b4 100644
--- a/libavfilter/vf_mp.c
+++ b/libavfilter/vf_mp.c
@@ -41,6 +41,7 @@
//FIXME maybe link the orig in
+//XXX: identical pix_fmt must be following with each others
static const struct {
int fmt;
enum PixelFormat pix_fmt;
@@ -785,13 +786,17 @@ static int query_formats(AVFilterContext *ctx)
{
AVFilterFormats *avfmts=NULL;
MPContext *m = ctx->priv;
+ enum PixelFormat lastpixfmt = PIX_FMT_NONE;
int i;
for(i=0; conversion_map[i].fmt; i++){
av_log(ctx, AV_LOG_DEBUG, "query: %X\n", conversion_map[i].fmt);
if(m->vf.query_format(&m->vf, conversion_map[i].fmt)){
av_log(ctx, AV_LOG_DEBUG, "supported,adding\n");
- avfilter_add_format(&avfmts, conversion_map[i].pix_fmt);
+ if (conversion_map[i].pix_fmt != lastpixfmt) {
+ avfilter_add_format(&avfmts, conversion_map[i].pix_fmt);
+ lastpixfmt = conversion_map[i].pix_fmt;
+ }
}
}
More information about the ffmpeg-cvslog
mailing list