[FFmpeg-cvslog] r26289 - trunk/libavcodec/truemotion2.c

[Baptiste Coudurier]

On 1/10/11 11:55 PM, Stefano Sabatini wrote:
> On date Tuesday 2011-01-11 02:31:01 +0100, Michael Niedermayer wrote:
>> On Mon, Jan 10, 2011 at 06:56:35PM +0100, Reimar D?ffinger wrote:
>>> On Mon, Jan 10, 2011 at 02:58:49PM +0100, Michael Niedermayer wrote:
>>>> On Mon, Jan 10, 2011 at 08:12:57AM +0200, Kostya wrote:
>>>>> On Sun, Jan 09, 2011 at 09:41:52PM +0100, Stefano Sabatini wrote:
>>>>> [...]
>>>>>>
>>>>>> People, plese try to use meaningful error codes, they help calling
>>>>>> code to detect and report which is the cause of the problem, -1
>>>>>> corresponds to EPERM which is not the correct reason most of the
>>>>>> times.
>>>>>
>>>>> This idea has not been bikeshedded enough. But in general who cares what
>>>>> error was returned by decoder? -1 is just our way to say "generic error,
>>>>> we don't care about actual code"
>>>>
>>>> agree
>>>
>>> I understood the intial mail to mean that the main problem is that applications
>>> that try to make the value into an error string end up claiming the error was
>>> "permission denied", which can be really confusing.
> 
> $ ffmpeg -i foo.avi -t 0 foo.nut
> ...
> $ ffplay foo.nut
> [...]
> [nut @ 0x9feadb0] EOF before video frames
> slow.nut: Operation not permitted
> 
> check cmdutils.c:print_error

Well, this must be fixed. I agree with others, -1 is general error in
ffmpeg.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org