[FFmpeg-cvslog] r26302 - trunk/libavformat/electronicarts.c

[Stefano Sabatini]

On date Monday 2011-01-10 20:38:15 +0100, Stefano Sabatini wrote:
> On date Monday 2011-01-10 14:10:23 -0500, Ronald S. Bultje wrote:
> > Hi,
> > 
> > On Mon, Jan 10, 2011 at 7:56 AM, pross <subversion at mplayerhq.hu> wrote:
> > > Author: pross
> > > Date: Mon Jan 10 13:56:50 2011
> > > New Revision: 26302
> > >
> > > Log:
> > > electronicarts: prevent endless loop opportunity in process_audio_header_elements()
> > > Fixes issue2529.
> [...]
> > This seems to have broken FATE, or one of the previous commits in this
> > file. You do run make fate after every change, right?
> 
> I believe it's OK not to require devels to "make fate" at every
> change, at least not for non really critical commits (e.g. framework
> changes). Developer time is our most precious resource, and since we
> have the luxury of FATE I think it is acceptable not to be too
> demanding with testing (as per policy).

Forget the comment, I suppose you just proposed to make test for the
codec at hand, which makes sense, sorry for the noise (but the
consideration on the break-mail-o-matic still applies).