[FFmpeg-cvslog] r26289 - trunk/libavcodec/truemotion2.c

[Michael Niedermayer]

On Mon, Jan 10, 2011 at 08:12:57AM +0200, Kostya wrote:
> On Sun, Jan 09, 2011 at 09:41:52PM +0100, Stefano Sabatini wrote:
> [...]
> > 
> > People, plese try to use meaningful error codes, they help calling
> > code to detect and report which is the cause of the problem, -1
> > corresponds to EPERM which is not the correct reason most of the
> > times.
> 
> This idea has not been bikeshedded enough. But in general who cares what
> error was returned by decoder? -1 is just our way to say "generic error,
> we don't care about actual code"

agree

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20110110/f1b19c38/attachment.pgp>