[FFmpeg-cvslog] r26215 - trunk/libavcodec/mpegvideo_enc.c

[Michael Niedermayer]

On Tue, Jan 04, 2011 at 08:14:23PM +0100, Stefano Sabatini wrote:
> On date Tuesday 2011-01-04 19:57:16 +0100, michael wrote:
> > Author: michael
> > Date: Tue Jan  4 19:57:16 2011
> > New Revision: 26215
> > 
> > Log:
> > Fix YUV444P LJPEG encoding.
> > 
> > Modified:
> >    trunk/libavcodec/mpegvideo_enc.c
> > 
> > Modified: trunk/libavcodec/mpegvideo_enc.c
> > ==============================================================================
> > --- trunk/libavcodec/mpegvideo_enc.c	Tue Jan  4 19:18:01 2011	(r26214)
> > +++ trunk/libavcodec/mpegvideo_enc.c	Tue Jan  4 19:57:16 2011	(r26215)
> > @@ -252,6 +252,12 @@ av_cold int MPV_encode_init(AVCodecConte
> >          }
> >          break;
> >      case CODEC_ID_LJPEG:
> > +        if(avctx->pix_fmt != PIX_FMT_YUVJ420P && avctx->pix_fmt != PIX_FMT_YUVJ422P && avctx->pix_fmt != PIX_FMT_YUVJ444P && avctx->pix_fmt != PIX_FMT_RGB32 &&
> > +           ((avctx->pix_fmt != PIX_FMT_YUV420P && avctx->pix_fmt != PIX_FMT_YUV422P && avctx->pix_fmt != PIX_FMT_YUV444P) || avctx->strict_std_compliance>FF_COMPLIANCE_UNOFFICIAL)){
> > +            av_log(avctx, AV_LOG_ERROR, "colorspace not supported in LJPEG\n");
> 
> While at it, please also provide some hint about what the user has to
> do to fix the problem without possibly use a debugger, e.g.:

that would be greping the source for the message at worst, but i see your point
of course


> "Invalid colorspace %s, only yuv420p, yuvj420p, and yuv444p are supported in LJPEG."

The user isnt supposed to see this error message, as there is AVCodec.pix_fmts
and the user app should not use what is not in that list. And for *jpeg with
strict_std_compliance low enough it should use an alternative list.


>
> > +            return -1;
> 
> and please meaningful error codes...

Changing a single one out of 50 error cases is not a good idea, 

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20110105/2d09198a/attachment.pgp>