[FFmpeg-cvslog] mp3enc: write ISO8859-1 instead of UTF-16 when possible

Anton Khirnov anton
Sun Feb 6 22:47:59 CET 2011


On Sun, Feb 06, 2011 at 10:02:17PM +0100, Arpi wrote:
> Hi,
> 
> this code is better than nothing but far from being perfect and far from
> being what the comment/commitmsg says.
> 
> iso 8859-1 charset are 32..255 and not 1..127 what the check verifies.
> a correct check and conversion although requires utf8 decoding, which
> is a bit tricky, especially if you check for bougus data, for example
> the string-termitor zero byte after an utf8 prefix...
Well spotted, thank you.
I don't think handling the 128-255 range is worth the effort.
Lower bound fixed.

-- 
Anton Khirnov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20110206/30adba34/attachment.pgp>



More information about the ffmpeg-cvslog mailing list