[FFmpeg-cvslog] pthread: fixed thread initialization issues related to thread-safe buffer allocator

Anatoliy Wasserman git at videolan.org
Thu Dec 8 02:33:56 CET 2011


ffmpeg | branch: master | Anatoliy Wasserman <anatoliy.wasserman at yandex.ru> | Wed Dec  7 14:14:49 2011 -0800| [6778f9d9f225cd9ec33ac49a5ec29f3542f980c8] | committer: Michael Niedermayer

pthread: fixed thread initialization issues related to thread-safe buffer allocator

Signed-off-by: Anatoliy Wasserman <anatoliy.wasserman at yandex.ru>
Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=6778f9d9f225cd9ec33ac49a5ec29f3542f980c8
---

 libavcodec/libopenjpegdec.c |    2 --
 libavcodec/pthread.c        |    6 ++++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/libavcodec/libopenjpegdec.c b/libavcodec/libopenjpegdec.c
index baa516b..ca3ef5f 100644
--- a/libavcodec/libopenjpegdec.c
+++ b/libavcodec/libopenjpegdec.c
@@ -241,8 +241,6 @@ static int libopenjpeg_decode_frame(AVCodecContext *avctx,
         return -1;
     }
 
-    ff_thread_finish_setup(avctx);
-
     ctx->dec_params.cp_limit_decoding = NO_LIMITATION;
     ctx->dec_params.cp_reduce = avctx->lowres;
     // Tie decoder with decoding parameters
diff --git a/libavcodec/pthread.c b/libavcodec/pthread.c
index 8aac89f..2154163 100644
--- a/libavcodec/pthread.c
+++ b/libavcodec/pthread.c
@@ -301,7 +301,7 @@ static attribute_align_arg void *frame_worker_thread(void *arg)
 
         if (fctx->die) break;
 
-        if (!codec->update_thread_context && avctx->thread_safe_callbacks)
+        if (!codec->update_thread_context && (avctx->thread_safe_callbacks || avctx->get_buffer == avcodec_default_get_buffer))
             ff_thread_finish_setup(avctx);
 
         pthread_mutex_lock(&p->mutex);
@@ -403,6 +403,7 @@ static void update_context_from_user(AVCodecContext *dst, AVCodecContext *src)
 
     dst->frame_number     = src->frame_number;
     dst->reordered_opaque = src->reordered_opaque;
+    dst->thread_safe_callbacks = src->thread_safe_callbacks;
 #undef copy_fields
 }
 
@@ -828,7 +829,8 @@ int ff_thread_get_buffer(AVCodecContext *avctx, AVFrame *f)
     }
 
     if (p->state != STATE_SETTING_UP &&
-        (avctx->codec->update_thread_context || !avctx->thread_safe_callbacks)) {
+        (avctx->codec->update_thread_context || (!avctx->thread_safe_callbacks &&
+                avctx->get_buffer != avcodec_default_get_buffer))) {
         av_log(avctx, AV_LOG_ERROR, "get_buffer() cannot be called after ff_thread_finish_setup()\n");
         return -1;
     }



More information about the ffmpeg-cvslog mailing list