[FFmpeg-cvslog] matroskaenc: saner default codecs.

[compn]

On Mon, 22 Aug 2011 08:26:02 -0700, Ronald S. Bultje wrote:
>Hi,
>
>On Aug 22, 2011 8:12 AM, "compn" <tempn at twmi.rr.com> wrote:
>>
>> On Mon, 22 Aug 2011 15:32:48 +0200 (CEST), Anton Khirnov wrote:
>> >ffmpeg | branch: master | Anton Khirnov <anton at khirnov.net> | Sat Aug 20
>16:02:22 2011 +0200| [3436c4a368aca1bdcbf28bdfc996903460263de0] | committer:
>Anton Khirnov
>> >
>> >matroskaenc: saner default codecs.
>> >-    .audio_codec       = CODEC_ID_MP2,
>> >+#if CONFIG_LIBVORBIS_ENCODER
>> >+    .audio_codec       = CODEC_ID_VORBIS,
>> >+#else
>> >+    .audio_codec       = CODEC_ID_AC3,
>> >+#endif
>>
>> why not mp3 (as first choice)?
>
>It depends on an external lib (Libmp3lame). Vorbis surely is better.

isnt libvorbis an external lib too?

i remember the internal vorbis encoder having poor audio quality.
i'm not seeing anything in the git logs about people working on it. 

ffmpeg -i in.avi -vcodec copy -acodec vorbis out.mkv 
ffmpeg version N-32071-g276f43b, Copyright (c) 2000-2011 the FFmpeg
developers built on Aug 23 2011 11:01:40 with gcc 4.6.1
...
encoder 'vorbis' is experimental and might produce bad results.
Add '-strict experimental' if you want to use it.
Or use the non experimental encoder 'libvorbis'.

since i have libvorbis installed, it uses libvorbis by default:

Input #0, avi, from 'sleepyheads.avi':
    Stream #0.1: Audio: mp3 (U[0][0][0] / 0x0055), 48000 Hz, stereo,
s16, 128 kb/s

Output #0, matroska, to 'out.mkv':
    Stream #0.1: Audio: vorbis (oV[0][0] / 0x566F), 48000 Hz, stereo,
s16, 64 kb/s

default is 64kb? sucks! 

i guess -acodec libmp3lame defaults to 64kb too. should probably fix
that to 128kb/s while you are at it. :)

-compn