[FFmpeg-cvslog] libx264: add 'aq_mode' private option.

Anton Khirnov git at videolan.org
Wed Aug 24 20:34:16 CEST 2011


ffmpeg | branch: master | Anton Khirnov <anton at khirnov.net> | Mon Aug 22 07:55:34 2011 +0200| [85254fcb46b4af38510685bc48ae6aa557f861aa] | committer: Anton Khirnov

libx264: add 'aq_mode' private option.

Deprecate corresponding global option.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=85254fcb46b4af38510685bc48ae6aa557f861aa
---

 libavcodec/avcodec.h |    4 +++-
 libavcodec/libx264.c |   15 ++++++++++++++-
 libavcodec/options.c |    4 +++-
 3 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index bff4b8f..e789a52 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
@@ -2722,6 +2722,7 @@ typedef struct AVCodecContext {
      */
     int weighted_p_pred;
 
+#if FF_API_X264_GLOBAL_OPTS
     /**
      * AQ mode
      * 0: Disabled
@@ -2730,7 +2731,8 @@ typedef struct AVCodecContext {
      * - encoding: Set by user
      * - decoding: unused
      */
-    int aq_mode;
+    attribute_deprecated int aq_mode;
+#endif
 
     /**
      * AQ strength
diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c
index cafca18..7d6f140 100644
--- a/libavcodec/libx264.c
+++ b/libavcodec/libx264.c
@@ -43,6 +43,7 @@ typedef struct X264Context {
     int fastfirstpass;
     float crf;
     int cqp;
+    int aq_mode;
 } X264Context;
 
 static void X264_log(void *p, int level, const char *fmt, va_list args)
@@ -234,7 +235,6 @@ static av_cold int X264_init(AVCodecContext *avctx)
         x4->params.analyse.i_me_method = X264_ME_TESA;
     else x4->params.analyse.i_me_method = X264_ME_HEX;
 
-    x4->params.rc.i_aq_mode               = avctx->aq_mode;
     x4->params.rc.f_aq_strength           = avctx->aq_strength;
     x4->params.rc.i_lookahead             = avctx->rc_lookahead;
 
@@ -308,6 +308,15 @@ static av_cold int X264_init(AVCodecContext *avctx)
     x4->params.rc.f_pb_factor             = avctx->b_quant_factor;
     x4->params.analyse.i_chroma_qp_offset = avctx->chromaoffset;
 
+#if FF_API_X264_GLOBAL_OPTS
+    if (avctx->aq_mode >= 0)
+        x4->params.rc.i_aq_mode = avctx->aq_mode;
+#endif
+
+    if (x4->aq_mode >= 0)
+        x4->params.rc.i_aq_mode = x4->aq_mode;
+
+
     if (x4->fastfirstpass)
         x264_param_apply_fastfirstpass(&x4->params);
 
@@ -382,6 +391,10 @@ static const AVOption options[] = {
     { "fastfirstpass", "Use fast settings when encoding first pass",      OFFSET(fastfirstpass), FF_OPT_TYPE_INT,    { 1 }, 0, 1, VE},
     { "crf",           "Select the quality for constant quality mode",    OFFSET(crf),           FF_OPT_TYPE_FLOAT,  {-1 }, -1, FLT_MAX, VE },
     { "cqp",           "Constant quantization parameter rate control method",OFFSET(cqp),        FF_OPT_TYPE_INT,    {-1 }, -1, INT_MAX, VE },
+    { "aq_mode",       "AQ method",                                       OFFSET(aq_mode),       FF_OPT_TYPE_INT,    {-1 }, -1, INT_MAX, VE, "aq_mode"},
+    { "none",          NULL,                              0, FF_OPT_TYPE_CONST, {X264_AQ_NONE},         INT_MIN, INT_MAX, VE, "aq_mode" },
+    { "variance",      "Variance AQ (complexity mask)",   0, FF_OPT_TYPE_CONST, {X264_AQ_VARIANCE},     INT_MIN, INT_MAX, VE, "aq_mode" },
+    { "autovariance",  "Auto-variance AQ (experimental)", 0, FF_OPT_TYPE_CONST, {X264_AQ_AUTOVARIANCE}, INT_MIN, INT_MAX, VE, "aq_mode" },
     { NULL },
 };
 
diff --git a/libavcodec/options.c b/libavcodec/options.c
index 38ac986..290f932 100644
--- a/libavcodec/options.c
+++ b/libavcodec/options.c
@@ -439,7 +439,9 @@ static const AVOption options[]={
 {"psy", "use psycho visual optimization", 0, FF_OPT_TYPE_CONST, {.dbl = CODEC_FLAG2_PSY }, INT_MIN, INT_MAX, V|E, "flags2"},
 {"psy_rd", "specify psycho visual strength", OFFSET(psy_rd), FF_OPT_TYPE_FLOAT, {.dbl = 1.0 }, 0, FLT_MAX, V|E},
 {"psy_trellis", "specify psycho visual trellis", OFFSET(psy_trellis), FF_OPT_TYPE_FLOAT, {.dbl = 0 }, 0, FLT_MAX, V|E},
-{"aq_mode", "specify aq method", OFFSET(aq_mode), FF_OPT_TYPE_INT, {.dbl = 1 }, 0, INT_MAX, V|E},
+#if FF_API_X264_GLOBAL_OPTS
+{"aq_mode", "specify aq method", OFFSET(aq_mode), FF_OPT_TYPE_INT, {.dbl = -1 }, -1, INT_MAX, V|E},
+#endif
 {"aq_strength", "specify aq strength", OFFSET(aq_strength), FF_OPT_TYPE_FLOAT, {.dbl = 1.0 }, 0, FLT_MAX, V|E},
 {"rc_lookahead", "specify number of frames to look ahead for frametype", OFFSET(rc_lookahead), FF_OPT_TYPE_INT, {.dbl = 40 }, 0, INT_MAX, V|E},
 {"ssim", "ssim will be calculated during encoding", 0, FF_OPT_TYPE_CONST, {.dbl = CODEC_FLAG2_SSIM }, INT_MIN, INT_MAX, V|E, "flags2"},



More information about the ffmpeg-cvslog mailing list