[FFmpeg-cvslog] Support changing pixel formats on avfilter input.

[Stefano Sabatini]

On date Monday 2011-04-04 03:15:04 +0200, Michael Niedermayer wrote:
> On Sun, Apr 03, 2011 at 08:11:40PM +0200, Stefano Sabatini wrote:
> > On date Sunday 2011-04-03 18:20:09 +0200, Michael Niedermayer wrote:
> > > ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Wed Mar  9 15:13:59 2011 +0100| [7d948dc424c3620e351d27afdf933c99f9435467] | committer: Michael Niedermayer
> > > 
> > > Support changing pixel formats on avfilter input.
> > > Fix issue2217
> > > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > > 
> > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=7d948dc424c3620e351d27afdf933c99f9435467
> > > ---
> > > 
> > >  ffmpeg.c                  |    5 ++-
> > >  libavfilter/vsrc_buffer.c |   53 +++++++++++++++++++++++++++++++++++++++++++-
> > >  libavfilter/vsrc_buffer.h |    4 +++
> > >  3 files changed, 58 insertions(+), 4 deletions(-)
> > 
> > Please revert this, this is not the proper way to fix it (and is
> > introducing several design problems).
> 
> elaborate please
> i know this isnt ideal but ideal is not going to happen anytime soon
> and this works the code before crashed

It is adding a dependency on libswscale to vsrc_buffer

It is extending a problematic API (and thus breaking my vsrc_buffer patches)

It's not the proper way to fix it, this should be done by implementing
filterchain re-configuration rather than adding an hack in a random
source. I don't mind if you add the code to ffmpeg.c, but extending a
public interface this way is not acceptable IMO.
-- 
FFmpeg = Frightening Furious Muttering Pacific Extravagant Gigant