[FFmpeg-cvslog] patch checklist:git format-patch
Michael Niedermayer
git at videolan.org
Sun Apr 3 03:29:00 CEST 2011
ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Sun Apr 3 02:47:17 2011 +0200| [71aed40b56af81d46c19620af5c4579703167475] | committer: Michael Niedermayer
patch checklist:git format-patch
Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=71aed40b56af81d46c19620af5c4579703167475
---
doc/developer.texi | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/doc/developer.texi b/doc/developer.texi
index 04cd331..cf80528 100644
--- a/doc/developer.texi
+++ b/doc/developer.texi
@@ -321,7 +321,7 @@ send a reminder by email. Your patch should eventually be dealt with.
@item
Does fate pass with the patch applied? (make fate)
@item
- Is the patch a unified diff?
+ Was the patch generated with git format-patch or send-email?
@item
Is the patch against latest FFmpeg git master branch?
@item
@@ -342,9 +342,6 @@ send a reminder by email. Your patch should eventually be dealt with.
tools/trasher and the noise bitstream filter. Your decoder or demuxer
should not crash or end in a (near) infinite loop when fed damaged data.
@item
- Is the patch created from the root of the source tree, so it can be
- applied with @code{patch -p0}?
- at item
Does the patch not mix functional and cosmetic changes?
@item
Did you add tabs or trailing whitespace to the code? Both are forbidden.
@@ -379,8 +376,6 @@ send a reminder by email. Your patch should eventually be dealt with.
@item
Lines with similar content should be aligned vertically when doing so
improves readability.
- at item
- Did you provide a suggestion for a clear commit log message?
@end enumerate
@section Patch review process
More information about the ffmpeg-cvslog
mailing list