[FFmpeg-cvslog] r32368 - in trunk/libswscale: swscale.h utils.c

[Ramiro Polla]

On Sun, Sep 26, 2010 at 4:33 PM, michael <subversion at mplayerhq.hu> wrote:
> Author: michael
> Date: Sun Sep 26 21:33:57 2010
> New Revision: 32368
>
> Log:
> Split alloc and init of context so that parameters can be set in the context
> instead of requireing being passed through function parameters. This also
> makes sws work with AVOptions.

Thanks

> Modified:
> ? trunk/libswscale/swscale.h
> ? trunk/libswscale/utils.c
>
> Modified: trunk/libswscale/swscale.h
> ==============================================================================
> --- trunk/libswscale/swscale.h ?Sun Sep 26 21:33:48 2010 ? ? ? ?(r32367)
> +++ trunk/libswscale/swscale.h ?Sun Sep 26 21:33:57 2010 ? ? ? ?(r32368)
> @@ -144,6 +144,17 @@ int sws_isSupportedInput(enum PixelForma
> ?int sws_isSupportedOutput(enum PixelFormat pix_fmt);
>
> ?/**
> + * Alloctaes an empty SwsContext, this must be filled and passed to sws_init_context().
> + * For filling see AVOptions, options.c and sws_setColorspaceDetails().
> + */
> +struct SwsContext *sws_alloc_context(void);
> +
> +/**
> + * Initializs the swscaler context sws_context.
> + */
> +int sws_init_context(struct SwsContext *sws_context, SwsFilter *srcFilter, SwsFilter *dstFilter);

One thing that particularly bothers me are the filters and params
being part of the arguments in the function call to initialize a
context. I haven't checked extensively, but almost no one uses them
(except for mplayer), which leads to an extra "NULL, NULL, NULL" to a
bunch of code.

Minor hasn't been bumped so I think we can still consider this not
part of the api and still subject to changes, right?