[FFmpeg-cvslog] r25165 - in trunk: Changelog configure doc/filters.texi libavfilter/Makefile libavfilter/allfilters.c libavfilter/avfilter.h libavfilter/vf_frei0r.c

[Víctor Paesa]

Hi,

2010/9/24 M?ns Rullg?rd
>
> Stefano Sabatini writes:
>
> >> >> > @@ -1050,6 +1052,7 @@ HAVE_LIST="
> >> >> > ? ? ?poll_h
> >> >> > ? ? ?setrlimit
> >> >> > ? ? ?strerror_r
> >> >> > + ? ?strtok_r
> >> >> > ? ? ?struct_addrinfo
> >> >> > ? ? ?struct_ipv6_mreq
> >> >> > ? ? ?struct_sockaddr_in6
> >> >>
> >> >> I told you not to check for strtok_r. ?It exists on all POSIX systems,
> >> >> and frei0r doesn't work anywhere else (dlopen). ?Please remove this
> >> >> pointless check, and also please respect the review comments in future.
> >> >
> >> > POSIX => dlopen
> >> > but not:
> >> > dlopen => POSIX
> >> >
> >> > so if dlopen is present you can't infer that strtok_r exists.
> >> >
> >> > And note that we already have a check for strerror_r, which is
> >> > supported by POSIX but is not supported in MinGW, following the same
> >> > logic it makes sense to keep the check for strtok_r.
> >>
> >> We check for strerror_r because it causes an actual build failure if
> >> we do not. ?That is not the case for strtok_r. ?Gratuitous checks only
> >> make configure run slower and bloat the build system for no gain.
> >>
> >> For just about any function we use, no matter how standard, there
> >> surely exists some system, somewhere that doesn't have it.
> >
> > Check attached.
>
> Just to be sure, does frei0r work on Windows?

Yes, it does work.
But dynamic libraries end in ".dll" instead of ".so"

I propose to remove the ".so" hardcoded, and leave up to the user
to write explicitely "plugin.so" or "plugin.dll" in the command line.

Index: libavfilter/vf_frei0r.c
===================================================================
--- libavfilter/vf_frei0r.c     (revision 25200)
+++ libavfilter/vf_frei0r.c     (working copy)
@@ -191,7 +191,7 @@
 {
     char path[1024];

-    snprintf(path, sizeof(path), "%s%s.so", prefix, name);
+    snprintf(path, sizeof(path), "%s%s", prefix, name);
     av_log(ctx, AV_LOG_DEBUG, "Looking for frei0r effect in '%s'\n", path);
     return dlopen(path, RTLD_NOW|RTLD_LOCAL);
 }


Regards,
V?ctor