[FFmpeg-cvslog] r25146 - trunk/libavcodec/x86/h264dsp_mmx.c

[Ronald S. Bultje]

Hi,

On Sun, Sep 19, 2010 at 1:39 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> M?ns Rullg?rd <mans <at> mansr.com> writes:
>> >> x86: remove hack disabling sse2 h264 loop filter with 32-bit icc
>> >
>> > This broke icc 10.1.
>> >
>> > Please fix
>>
>> If you want the compiler fixed, you need to contact your Intel
>> representative. ?Is 10.1 even supported still?
>
> It is supported.
> You changed a file you do not maintain

I think Mans has enough credibility to commit patches that he feels
are appropriate.

> without testing

It was tested (by Vitor, on ICC 11.1, which is covered by the check
removed in this patch) and the alignment fix in configure made the
check unnecessary, so removal of the #ifdef felt appropriate.

> and without sending a patch.

The patch was discussed and OK'ed on IRC by me, Vitor and Mans.

I think the proper solution is to add ICC 10.1 to FATE (which
undoubtedly Mans is already working on), so we have access to a system
for detecting brokenness automatically and testing fixes.

Ronald