[FFmpeg-cvslog] r25128 - in trunk: configure libavcodec/libmp3lame.c

Carl Eugen Hoyos cehoyos
Thu Sep 16 00:22:40 CEST 2010


M?ns,

M?ns Rullg?rd <mans <at> mansr.com> writes:

> > -        lame_set_VBR_q(s->gfp, avctx->global_quality / (float)FF_QP2LAMBDA);
> > +        /* requires lame 3.98 or later */
> > +        lame_set_VBR_quality(s->gfp,
avctx->global_quality/(float)FF_QP2LAMBDA);
> 
> Why did you include that useless comment?  Imagine what it would look
> like if every function call had a comment like that beside it.

I don't disagree, but please just remove the line instead of ranting.

Carl Eugen




More information about the ffmpeg-cvslog mailing list