[FFmpeg-cvslog] r25076 - in trunk: libavcodec/Makefile libavcodec/arm/dsputil_init_arm.c libavcodec/avcodec.h libavcodec/dct-test.c libavcodec/dsputil.h libavcodec/h263dec.c libavcodec/libxvidff.c libavcodec/ppc/M...

[Måns Rullgård]

Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:

> On date Wednesday 2010-09-08 16:49:02 +0100, M?ns Rullg?rd wrote:
>> Diego Biurrun <diego at biurrun.de> writes:
>> 
>> > On Wed, Sep 08, 2010 at 05:07:14PM +0200, stefano wrote:
>> >> 
>> >> Log:
>> >> Move mm_support() from libavcodec to libavutil, make it a public
>> >> function and rename it to av_get_cpu_flags().
>> >
>> > ~/src/ffmpeg $ make -k checkheaders
>> > CC	libavutil/ppc/cpu.ho
>> > libavutil/ppc/cpu.h:42: error: no previous prototype for `av_get_cpu_flags'
>> > libavutil/ppc/cpu.h: In function `av_get_cpu_flags':
>> > libavutil/ppc/cpu.h:65: error: `AV_CPU_FLAG_ALTIVEC' undeclared (first use in this function)
>> > libavutil/ppc/cpu.h:65: error: (Each undeclared identifier is reported only once
>> > libavutil/ppc/cpu.h:65: error: for each function it appears in.)
>> > make: *** [libavutil/ppc/cpu.ho] Error 1
>> > make: Target `checkheaders' not remade because of errors.
>> 
>> This needs lots of fixes.  Sorry I didn't have time to review it.
>> I'll try to fix it tonight.
>
> Can you elaborate?

Functions defined in header files.  YUCK.

> I believed you already reviewed that, otherwise I wouldn't had
> committed.

If I don't reply, I haven't reviews.  It's that simple.  I didn't
reply to this.

-- 
M?ns Rullg?rd
mans at mansr.com