[FFmpeg-cvslog] r25605 - trunk/libavcodec/bink.c

[Michael Niedermayer]

On Sat, Oct 30, 2010 at 05:53:55PM -0200, Ramiro Polla wrote:
> On Sat, Oct 30, 2010 at 5:51 PM, ramiro <subversion at mplayerhq.hu> wrote:
> > Author: ramiro
> > Date: Sat Oct 30 21:51:46 2010
> > New Revision: 25605
> >
> > Log:
> > bink: make bink_rlelens static (it's only used in this file)
> >
> > Modified:
> > ? trunk/libavcodec/bink.c
> >
> > Modified: trunk/libavcodec/bink.c
> > ==============================================================================
> > --- trunk/libavcodec/bink.c ? ? Sat Oct 30 19:14:22 2010 ? ? ? ?(r25604)
> > +++ trunk/libavcodec/bink.c ? ? Sat Oct 30 21:51:46 2010 ? ? ? ?(r25605)
> > @@ -325,7 +325,7 @@ static int read_motion_values(AVCodecCon
> > ? ? return 0;
> > ?}
> >
> > -const uint8_t bink_rlelens[4] = { 4, 8, 12, 32 };
> > +static const uint8_t bink_rlelens[4] = { 4, 8, 12, 32 };
> >
> > ?static int read_block_types(AVCodecContext *avctx, GetBitContext *gb, Bundle *b)
> > ?{
> 
> OKed by Kostya on IRC.
> 
> btw is it ok to just go and add static to data where it's clearly been
> forgotten? (like this one which is only used in this file)

yes, if you fix the compilation failures when you are wrong ;)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20101031/2a567d6c/attachment.pgp>