[FFmpeg-cvslog] r25531 - trunk/libavformat/img2.c

[Michael Niedermayer]

On Thu, Oct 21, 2010 at 01:01:56PM -0200, Ramiro Polla wrote:
> On Wed, Oct 20, 2010 at 11:59 PM, Pascal Massimino
> <pascal.massimino at gmail.com> wrote:
> > Ramiro,
> > On Wed, Oct 20, 2010 at 6:44 PM, Ramiro Polla <ramiro.polla at gmail.com>wrote:
> >> On Wed, Oct 20, 2010 at 10:57 PM, skal <subversion at mplayerhq.hu> wrote:
> >> [...]
> >> > @@ -413,56 +413,51 @@ static int img_write_packet(AVFormatCont
> >> > ?/* input */
> >> > ?#if CONFIG_IMAGE2_DEMUXER
> >> > ?AVInputFormat image2_demuxer = {
> >> > - ? ?"image2",
> >> > - ? ?NULL_IF_CONFIG_SMALL("image2 sequence"),
> >> > - ? ?sizeof(VideoData),
> >> > - ? ?image_probe,
> >> > - ? ?img_read_header,
> >> > - ? ?img_read_packet,
> >> > - ? ?NULL,
> >> > - ? ?NULL,
> >> > - ? ?NULL,
> >> > - ? ?AVFMT_NOFILE,
> >> > + ? ?.name = "image2",
> >> > + ? ?.long_name = NULL_IF_CONFIG_SMALL("image2 sequence"),
> >> > + ? ?.priv_data_size = sizeof(VideoData),
> >> > + ? ?.read_probe = read_probe,
> >> > + ? ?.read_header = read_header,
> >> > + ? ?.read_packet = read_packet,
> >> > + ? ?.flags = AVFMT_NOFILE,
> >> > ?};
> >>
> >> Sorry for not commenting earlier, but it's quite handy while debugging
> >> to have a more descriptive name (img2_read_header for example).
> >> Otherwise you'll get only "read_header" which could be from many other
> >> demuxers.
> >>
> >
> > as in $attached?
> 
> Yes, like that. Michael is the maintainer though, so you'd have to
> wait for his call...

I prefer not to prefix all functions by the file name
id rather see the debuggers user interface improved ;)


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20101021/d283408f/attachment.pgp>