[FFmpeg-cvslog] r25385 - trunk/libavformat/mpegenc.c

[Rob]

On 16 October 2010 04:57, Jason Garrett-Glaser <darkshikari at gmail.com> wrote:
> On Thu, Oct 7, 2010 at 3:24 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> On Wed, Oct 06, 2010 at 08:16:20PM -0700, Alex Converse wrote:
>>> On Wed, Oct 6, 2010 at 6:57 PM, michael <subversion at mplayerhq.hu> wrote:
>>> >
>>> > Author: michael
>>> > Date: Thu Oct ?7 03:57:39 2010
>>> > New Revision: 25385
>>> >
>>> > Log:
>>> > Warn if muxing mpeg ps is attempted without a VBV buffer size.
>>> >
>>> > Modified:
>>> > ? trunk/libavformat/mpegenc.c
>>> >
>>> > Modified: trunk/libavformat/mpegenc.c
>>> > ==============================================================================
>>> > --- trunk/libavformat/mpegenc.c Thu Oct ?7 03:57:35 2010 ? ? ? ?(r25384)
>>> > +++ trunk/libavformat/mpegenc.c Thu Oct ?7 03:57:39 2010 ? ? ? ?(r25385)
>>> > @@ -367,8 +367,10 @@ static int mpeg_mux_init(AVFormatContext
>>> > ? ? ? ? ? ? stream->id = mpv_id++;
>>> > ? ? ? ? ? ? if (st->codec->rc_buffer_size)
>>> > ? ? ? ? ? ? ? ? stream->max_buffer_size = 6*1024 + st->codec->rc_buffer_size/8;
>>> > - ? ? ? ? ? ?else
>>> > + ? ? ? ? ? ?else{
>>>
>>> Just two days ago people asked you to put whitespace after keywords.
>>
>> yes and iam not doing it, you should vote on me being leader accordingly.
>
> OK, I will pipe all comments about cosmetics (spacing, alignment,
> splitting cosmetics from functional changes, etc) from you to
> /dev/null from now on. ?Thanks for saving me the hassle.

It seems that since this outburst Michael has done somewhat of an
about-face on the issue as he went on to edit patcheck and such just
after to check for certain whitespace issues, precisely like the one
mentioned. I don't recall if the guidelines/policies were clarified
and the 'inspired by' were changed to something less easily abused.

Regards,
Rob