[FFmpeg-cvslog] r25385 - trunk/libavformat/mpegenc.c

[Michael Niedermayer]

On Fri, Oct 08, 2010 at 09:16:48AM -0700, Alex Converse wrote:
> On Fri, Oct 8, 2010 at 8:45 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Thu, Oct 07, 2010 at 09:22:38PM -0700, Alex Converse wrote:
> >> On Thursday, October 7, 2010, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > On Wed, Oct 06, 2010 at 08:16:20PM -0700, Alex Converse wrote:
> >> >> On Wed, Oct 6, 2010 at 6:57 PM, michael <subversion at mplayerhq.hu> wrote:
> >> >> >
> >> >> > Author: michael
> >> >> > Date: Thu Oct ?7 03:57:39 2010
> >> >> > New Revision: 25385
> >> >> >
> >> >> > Log:
> >> >> > Warn if muxing mpeg ps is attempted without a VBV buffer size.
> >> >> >
> >> >> > Modified:
> >> >> > ? trunk/libavformat/mpegenc.c
> >> >> >
> >> >> > Modified: trunk/libavformat/mpegenc.c
> >> >> > ==============================================================================
> >> >> > --- trunk/libavformat/mpegenc.c Thu Oct ?7 03:57:35 2010 ? ? ? ?(r25384)
> >> >> > +++ trunk/libavformat/mpegenc.c Thu Oct ?7 03:57:39 2010 ? ? ? ?(r25385)
> >> >> > @@ -367,8 +367,10 @@ static int mpeg_mux_init(AVFormatContext
> >> >> > ? ? ? ? ? ? stream->id = mpv_id++;
> >> >> > ? ? ? ? ? ? if (st->codec->rc_buffer_size)
> >> >> > ? ? ? ? ? ? ? ? stream->max_buffer_size = 6*1024 + st->codec->rc_buffer_size/8;
> >> >> > - ? ? ? ? ? ?else
> >> >> > + ? ? ? ? ? ?else{
> >> >>
> >> >> Just two days ago people asked you to put whitespace after keywords.
> >> >
> >> > yes and iam not doing it, you should vote on me being leader accordingly.
> >> >
> >>
> >> If there were time left on the vote I absolutely would change my choice to B
> >
> > time shall not prevent you or anyone else from making such change.
> > if you consider a space between else and { important enough ...
> >
> 
> >> > yes and iam not doing it, you should vote on me being leader accordingly.
> 
> The reason is not the space but the attitude that the rules and
> conventions don't apply to you.

There is no such rule

Yes maybe 5 people somewhere on IRC agreed to something, i dont know but that
makes about as much a binding rule for everyone as 5 workers in the bar
agreeing to something is binding for the other 500 of their coleges and their
boss is.

I hope you see what iam trying to say and dont missunderstand me, ive no
intent to flame iam just trying to point out that rules are written in the
policy and that they need to be publically and carefully discussed and agreed
to by people. What doesnt make it into the policy is not something  that was
sufficiently discussed and agreed upon.

And as we are at the subject before we all go into a rewrite the policy
crussade, please everyone cool down, messing with policy and rules requires
a clear mind and carefull thoughts as stringing us down in more rules will
do more harm than good. (id like a variables need to be understandable without
knowing the spec rule but i also know this will do harm by angering some
developers)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20101008/783f221e/attachment.pgp>