[FFmpeg-cvslog] r25385 - trunk/libavformat/mpegenc.c

[Carl Eugen Hoyos]

Diego Biurrun <diego <at> biurrun.de> writes:

> >    We refuse source indentation and other cosmetic changes if they are mixed
> >    with functional changes, such commits will be rejected and removed. Every
> >    developer has his own indentation style, you should not change it. Of
> >    course if you (re)write something, you can use your own style, even
> >    though we would prefer if the indentation throughout FFmpeg was
> >    consistent (Many projects force a given indentation style - we do not.).
> >    If you really need to make indentation changes (try to avoid this),
> >    separate them strictly from real changes.

> This paragraph was added by you without consultation

Note that I consider this sentence in its context vs the actual facts a lie.

> and you break the
> formatting of files that already use a consistent indentation style
> without second thought.

...

> > This says 'INSPIRED by 'indent -i4 -kr -nut'' it does not say follow the
> > indent output to the last whitespace is mandatory
> 
> The "inspired" is a change unilaterally approved by yourself.

Gmane might be broken but I fail to see your protest:
http://thread.gmane.org/gmane.comp.video.ffmpeg.cvs/24979

Now either:
1) fork
2) start a new vote
3) or go fixing build system bugs

I would strongly prefer 3), but I will not change my vote!

Carl Eugen