[FFmpeg-cvslog] r25385 - trunk/libavformat/mpegenc.c

Stefano Sabatini stefano.sabatini-lala
Thu Oct 7 13:15:22 CEST 2010


On date Thursday 2010-10-07 12:24:15 +0200, Michael Niedermayer wrote:
> On Wed, Oct 06, 2010 at 08:16:20PM -0700, Alex Converse wrote:
> > On Wed, Oct 6, 2010 at 6:57 PM, michael <subversion at mplayerhq.hu> wrote:
> > >
> > > Author: michael
> > > Date: Thu Oct ?7 03:57:39 2010
> > > New Revision: 25385
> > >
> > > Log:
> > > Warn if muxing mpeg ps is attempted without a VBV buffer size.
> > >
> > > Modified:
> > > ? trunk/libavformat/mpegenc.c
> > >
> > > Modified: trunk/libavformat/mpegenc.c
> > > ==============================================================================
> > > --- trunk/libavformat/mpegenc.c Thu Oct ?7 03:57:35 2010 ? ? ? ?(r25384)
> > > +++ trunk/libavformat/mpegenc.c Thu Oct ?7 03:57:39 2010 ? ? ? ?(r25385)
> > > @@ -367,8 +367,10 @@ static int mpeg_mux_init(AVFormatContext
> > > ? ? ? ? ? ? stream->id = mpv_id++;
> > > ? ? ? ? ? ? if (st->codec->rc_buffer_size)
> > > ? ? ? ? ? ? ? ? stream->max_buffer_size = 6*1024 + st->codec->rc_buffer_size/8;
> > > - ? ? ? ? ? ?else
> > > + ? ? ? ? ? ?else{
> > 
> > Just two days ago people asked you to put whitespace after keywords.
> 
> yes and iam not doing it, you should vote on me being leader accordingly.
> 
> also IMHO, the one who said it loud enough for me to remember it at all is
> diego (on the phone ;) ) and he
> neither maintains C code nor is he contributing C code. And this is stuff
> that should be decided by the people falling in these 2 categories
> 
> IMHO such whitespace cosmetics go too far and ive never asked others to
> follow such nitpickery. Especially not if they feel strongly about it
> 
> Its important that people have fun contributing to the project and to me
> this is not fun. Do people want to string up the leader (or for the matter of
> fact anyone) in rules that make it not fun for him to work?
> This feels backward to me, but maybe its just me.

Honestly, I can't see how adding some more spaces around may be "not
fun", also we never requested to fix already existing code, but simply
to do the effort to write new code using this style.

My problem with the "if(){" style is that it is inconsistent with what
most developers are already using (K&R), and IMO less readable, so if
we have to choose a style it's better to stick with K&R.

As for the consistency in style, why does it matter? I find a little
disturbing to read code written in mixed style (so it makes
contributing less fun for me at least), and casual contributors
usually tend to use a mixed style as well when there is not a
consistent style.

So I don't believe it is so important, but having to choose I'd prefer
to keep a consistent spacing style (K&R), as the gain seems greater
than the little effort required for it.



More information about the ffmpeg-cvslog mailing list