[FFmpeg-cvslog] r25383 - in trunk: libavformat/mpegenc.c tests/ref/lavf/mpg

[Baptiste Coudurier]

On 10/6/10 7:35 PM, Michael Niedermayer wrote:
> On Wed, Oct 06, 2010 at 05:40:30PM -0700, Baptiste Coudurier wrote:
>> Michael,
>>
>> On 10/06/2010 05:32 PM, michael wrote:
>>> Author: michael
>>> Date: Thu Oct  7 02:32:22 2010
>>> New Revision: 25383
>>>
>>> Log:
>>> Init SCR in mpeg muxer based on first DTS.
>>> This fixes issues if the first DTS is far away from 0.
>>>
>>> Modified:
>>>     trunk/libavformat/mpegenc.c
>>>     trunk/tests/ref/lavf/mpg
>>>
>>> Modified: trunk/libavformat/mpegenc.c
>>> ==============================================================================
>>> --- trunk/libavformat/mpegenc.c	Wed Oct  6 23:43:46 2010	(r25382)
>>> +++ trunk/libavformat/mpegenc.c	Thu Oct  7 02:32:22 2010	(r25383)
>>> @@ -1160,6 +1160,8 @@ static int mpeg_mux_write_packet(AVForma
>>>
>>>       pts= pkt->pts;
>>>       dts= pkt->dts;
>>> +    if(!s->last_scr)
>>> +        s->last_scr= dts;
>>
>> dts is negative for the first frame where there is delay
>> negative in PS/TS -> very big
> 
> yes, is that a problem? or rather where do you see the problem?
> 

This means scr would always wrap after the first frame. I'd rather have
the scr inited to dts+preload, but maybe I'm overlooking something.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org