[FFmpeg-cvslog] r25385 - trunk/libavformat/mpegenc.c

[Michael Niedermayer]

On Wed, Oct 06, 2010 at 07:05:22PM -0700, Baptiste Coudurier wrote:
> On 10/06/2010 06:57 PM, michael wrote:
>> Author: michael
>> Date: Thu Oct  7 03:57:39 2010
>> New Revision: 25385
>>
>> Log:
>> Warn if muxing mpeg ps is attempted without a VBV buffer size.
>>
>> Modified:
>>     trunk/libavformat/mpegenc.c
>>
>> Modified: trunk/libavformat/mpegenc.c
>> ==============================================================================
>> --- trunk/libavformat/mpegenc.c	Thu Oct  7 03:57:35 2010	(r25384)
>> +++ trunk/libavformat/mpegenc.c	Thu Oct  7 03:57:39 2010	(r25385)
>> @@ -367,8 +367,10 @@ static int mpeg_mux_init(AVFormatContext
>>               stream->id = mpv_id++;
>>               if (st->codec->rc_buffer_size)
>>                   stream->max_buffer_size = 6*1024 + st->codec->rc_buffer_size/8;
>> -            else
>> +            else{
>> +                av_log(ctx, AV_LOG_WARNING, "VBV buffer size not set, muxing may fail\n");
>>                   stream->max_buffer_size = 230*1024; //FIXME this is probably too small as default
>> +            }
>
> Humm, this will warn for every VBR encode. I'm not sure at all that is  
> wanted.

VBR has buffers too, so it needs a buffer size too

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20101007/c80ec2ad/attachment.pgp>