[FFmpeg-cvslog] r25343 - trunk/libavformat/rtsp.c

[Martin Storsjö]

On Tue, 5 Oct 2010, Diego Biurrun wrote:

> On Tue, Oct 05, 2010 at 02:33:39PM +0300, Martin Storsj? wrote:
> > On Tue, 5 Oct 2010, diego wrote:
> > > 
> > > Log:
> > > Remove some pointless CONFIG_RTSP_DEMUXER #ifdefs.
> > > They reside within a large CONFIG_RTSP_DEMUXER block and are thus pointless.
> > 
> > They're not pointless in their original intent, but in the way the code 
> > currently organized, they are. The separation between the SDP and RTSP 
> > demuxers was broken in January in rev 21020 by Ronald, when moving code 
> > around, trying to get rid of some forward declarations.
> > 
> > The attached patch readds these ifdefs, and moves code around so that the 
> > SDP demuxer is buildable without the RTSP code, as it should be.
> 
> How can the SDP demuxer be buildable without the RTSP code when it
> uses RTSP functions?

Some of the RTSP functions aren't really specific to RTSP itself, but only 
handle "receiving one or more RTP streams as specified in a SDP file". I 
guess they could be renamed sdp instead of rtsp for clarity. (They also 
use the RTSPState struct, which has both common fields and RTSP-specific 
fields.)

// Martin