[FFmpeg-cvslog] r25333 - in trunk/libavcore: avcore.h parseutils.c

[stefano]

Author: stefano
Date: Mon Oct  4 15:41:04 2010
New Revision: 25333

Log:
Use av_parse_and_eval_expr() in av_parse_video_rate(), simplify.

Modified:
   trunk/libavcore/avcore.h
   trunk/libavcore/parseutils.c

Modified: trunk/libavcore/avcore.h
==============================================================================
--- trunk/libavcore/avcore.h	Mon Oct  4 15:41:01 2010	(r25332)
+++ trunk/libavcore/avcore.h	Mon Oct  4 15:41:04 2010	(r25333)
@@ -28,7 +28,7 @@
 
 #define LIBAVCORE_VERSION_MAJOR  0
 #define LIBAVCORE_VERSION_MINOR  9
-#define LIBAVCORE_VERSION_MICRO  0
+#define LIBAVCORE_VERSION_MICRO  1
 
 #define LIBAVCORE_VERSION_INT   AV_VERSION_INT(LIBAVCORE_VERSION_MAJOR, \
                                                LIBAVCORE_VERSION_MINOR, \

Modified: trunk/libavcore/parseutils.c
==============================================================================
--- trunk/libavcore/parseutils.c	Mon Oct  4 15:41:01 2010	(r25332)
+++ trunk/libavcore/parseutils.c	Mon Oct  4 15:41:04 2010	(r25333)
@@ -23,6 +23,7 @@
 
 #include "parseutils.h"
 #include "libavutil/avutil.h"
+#include "libavutil/eval.h"
 
 typedef struct {
     const char *abbr;
@@ -115,9 +116,9 @@ int av_parse_video_size(int *width_ptr, 
 
 int av_parse_video_rate(AVRational *rate, const char *arg)
 {
-    int i;
+    int i, ret;
     int n = FF_ARRAY_ELEMS(video_rate_abbrs);
-    char *cp;
+    double res;
 
     /* First, we check our abbreviation table */
     for (i = 0; i < n; ++i)
@@ -127,20 +128,10 @@ int av_parse_video_rate(AVRational *rate
         }
 
     /* Then, we try to parse it as fraction */
-    cp = strchr(arg, '/');
-    if (!cp)
-        cp = strchr(arg, ':');
-    if (cp) {
-        char *cpp;
-        rate->num = strtol(arg, &cpp, 10);
-        if (cpp != arg || cpp == cp)
-            rate->den = strtol(cp+1, &cpp, 10);
-        else
-            rate->num = 0;
-    } else {
-        /* Finally we give up and parse it as double */
-        *rate = av_d2q(strtod(arg, 0), 1001000);
-    }
+    if ((ret = av_parse_and_eval_expr(&res, arg, NULL, NULL, NULL, NULL, NULL, NULL,
+                                      NULL, 0, NULL)) < 0)
+        return ret;
+    *rate = av_d2q(res, 1001000);
     if (rate->num <= 0 || rate->den <= 0)
         return AVERROR(EINVAL);
     return 0;