[FFmpeg-cvslog] r25278 - in trunk: ffmpeg.c libavutil/Makefile libavutil/assert.h libavutil/avutil.h libavutil/rational.c

[Stefano Sabatini]

On date Friday 2010-10-01 03:30:16 +0200, Michael Niedermayer wrote:
> On Thu, Sep 30, 2010 at 07:37:36PM -0400, Ronald S. Bultje wrote:
> > Hi,
> > 
> > 2010/9/30 M?ns Rullg?rd <mans at mansr.com>:
> > > michael <subversion at mplayerhq.hu> writes:
> > >> -#include <assert.h>
> > >> +#include "assert.h"
> > >
> > > Using the same name as a standard header is practically guaranteed to
> > > cause confusion and mysterious bugs.
> > 
> > I second this, can you please rename this to avassert.h if nothing else?
> 
> as said, feel free to rename it, to me there is no ambiguity between
> 
> #include <assert.h>
> and
> #include <libavutil/assert.h>

Note that we already have public headers which are named as standard
headers, e.g. libavutil/error.h and <error.h>.
  
> > (Review would've been nice - what problem does this solve exactly?)

+1.

Review for public API modifications should be *mandatory*, the
maintainer has the last choice but at least he should give the
opportunity for reviewing to the other developers.

[...]

Regards.
-- 
FFmpeg = Fascinating and Fascinating Marvellous Prodigious Ecstatic Gospel