[FFmpeg-cvslog] r23197 - trunk/libavcodec/libx264.c

[Reimar Döffinger]

On Wed, May 19, 2010 at 01:56:51PM -0700, Baptiste Coudurier wrote:
> On 05/19/2010 01:54 PM, Reimar D?ffinger wrote:
> >On Wed, May 19, 2010 at 10:48:29PM +0200, bcoudurier wrote:
> >>Author: bcoudurier
> >>Date: Wed May 19 22:48:29 2010
> >>New Revision: 23197
> >>
> >>Log:
> >>fix x264 encoding when delay is>  number of input frames
> >
> >Note that's not entirely correct, it was broken in all cases and would
> >drop the last frames regardless of how many input frames there were.
> 
> Can you please elaborate ? As soon as one frame was actually output
> by x264 I never realized this.

x264_encoder_encode will (under certain conditions) return no data at the
end even though there is still frame data pending.
In that case FFmpeg will still stop encoding and the last frames are lost.
I haven't tested with FFmpeg, but it certainly happened with mencoder,
should be easiest to see with man B-frames and lots of threads.
It might be that the issue existed only for certain revisions - I know it
didn't exist for really old x264 versions, and it might be that x264 was changed
in newer builds to avoid the issue.