[FFmpeg-cvslog] r31153 - in trunk/libswscale: bfin/internal_bfin.S bfin/swscale_bfin.c colorspace-test.c swscale.c swscale_internal.h swscale_template.c

[Michael Kostylev]

On Wed May 12 12:20:22 2010
Michael Kostylev wrote:

>>> Log:
>>> Use int instead of long to pass width parameters in non-public functions.
>>> long was being incorrectly used as an x86-sized register, both for 32 and 64
>>> bits, but this is not the case in win64.
>> 
>> I only saw the breakages on FATE now. I'll only be able to take a
>> closer look later on today in about 6 hours.
> 
> gcc-3.3 is in trouble with 
> YSCALEYUV2YV12X_ACCURATE:
>         packuswb                            %mm6, %mm4
>         movntq                              %mm4, (%rbp, %rax)
>         add                                 $8, %rax
>>       cmp                                 %r11d, %rax
>         lea                                 11*8(%rcx), %rdx
>         pxor                                %mm4, %mm4
>         pxor                                %mm5, %mm5
> 
> & YSCALEYUV2YV12X:
>         packuswb                            %mm4, %mm3
>         movntq                              %mm3, (%rdi, %rax)
>         add                                 $8, %rax
>>       cmp                                 %r10d, %rax
>         movq                                11*8+4*4*256*2+16(%rcx), %mm3
>         movq                                %mm3, %mm4
>         lea                                 11*8+4*4*256(%rcx), %rdx
> 
> Did not look at suncc yet.

{                 904  } packuswb  %mm6,  %mm4
{                 904  } movntq  %mm4, (%rcx,  %rax)
{                 904  } add $8,  %rax
{                 904  } cmp %esi,  %rax
{                 904  } lea 11*8+4*4*256(%rax),  %rdx
{                 904  } pxor  %mm4,  %mm4
{                 904  } pxor  %mm5,  %mm5

{                 914  } packuswb  %mm4,  %mm3
{                 914  } movntq  %mm3, (%rax,  %rax)
{                 914  } add $8,  %rax
{                 914  } cmp %esi,  %rax
{                 914  } movq 11*8+4*4*256*2+16(%rcx),  %mm3
{                 914  } movq  %mm3,  %mm4
{                 914  } lea 11*8+4*4*256(%rcx),  %rdx

Michael