[FFmpeg-cvslog] r22711 - trunk/libavcodec/tta.c

[Michael Niedermayer]

On Mon, Mar 29, 2010 at 07:24:23PM +0200, Reimar D?ffinger wrote:
> On Mon, Mar 29, 2010 at 12:31:12PM +0530, Jai Menon wrote:
> > On Mon, Mar 29, 2010 at 3:39 AM, Stefano Sabatini
> > <stefano.sabatini-lala at poste.it> wrote:
> > > On date Sunday 2010-03-28 19:17:48 +0200, jai_menon wrote:
> > >> + ? ? ? ? ? ?return -1;
> > >
> > > AVERROR_INVALIDDATA.
> > 
> > I'm not sure about this. For very high sample rate media, this check
> > might trigger and the data is clearly not invalid.
> 
> Since the user could provide a buffer large enough for it to work, I agree.
> I don't know what a good return value would be, something that clearly indicates
> that the only issue is that a output buffer was too small an providing a bigger
> one and retry will fix it might make sense.

EINVAL ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100330/7705dde9/attachment.pgp>