[FFmpeg-cvslog] r21681 - in trunk/libavcodec: h264.c h264_direct.c

[Uoti Urpala]

On Mon, 2010-02-08 at 01:08 +0100, michael wrote:
> Author: michael
> Date: Mon Feb  8 01:08:05 2010
> New Revision: 21681
> 
> Log:
> Set x264_build so that checks are simpler.

> -            if(h->x264_build > 0 && h->x264_build < 44)
> +            if(h->x264_build < 44U)

These changes cause corrupted output with a sample that has the x264
version and option details overwritten with '0' characters so the file
says "x264 - core 00000000000000000" (I guess the person making the file
didn't want to show the details for some reason...). Before "version 0"
was treated as an unknown version, after this commit it's treated as the
oldest possible known version.

The first x264 version to write a decimal-format version string used
version 20, so anything smaller than that could be declared invalid and
ignored. OTOH the current lavc code would also parse older hex-format
versions as '0' because of the leading "0x" - if anyone still cares
about files produced by those versions (unlikely?) then treating them as
oldest possible is probably correct, but that could be handled with a
special case if needed.