[FFmpeg-cvslog] r22522 - in trunk: configure libavcodec/Makefile libavcodec/dsputil.c libavcodec/dsputil.h libavcodec/dwt.c libavcodec/dwt.h libavcodec/ivi_dsp.c libavcodec/snow.c libavcodec/snow.h libavcodec/x86/...

[Michael Niedermayer]

On Sun, Mar 14, 2010 at 07:32:23PM -0400, Alex Converse wrote:
> On Sun, Mar 14, 2010 at 7:21 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sun, Mar 14, 2010 at 05:00:34PM -0400, Alex Converse wrote:
> >> On Sun, Mar 14, 2010 at 4:50 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > [...]
> >> > you can checkout with svn per date/time instead of revission then it
> >> > will get a matching revission for all externals
> >> >
> >>
> >> Which is great until someone gives you revision number and you need to
> >> reverse it into a timestamp. And if there are automated tools that can
> >> do this then why can't svn-co do it?
> >
> > ask the svn devels ...
> >
> >
> >>
> >> Furthermore SVN doesn't have any bisecting support so the point is
> >> somewhat moot.
> >>
> >> > also as we are speaking about a git switchover, if we choose to do this
> >> > please dont do it during gsoc, it would just make work harder to students
> >> > to learn a new vcs.
> >> >
> >>
> >
> >> Having worked on the aac-sbr code base which was set up like one of
> >> our soc projects, ditching our awful soc-svn repository format in
> >> favor of a real git branch easily doubled my productivity.
> >
> > like changing the variable names from random 2 letter names to
> > english words would have halfed it
> >
> 
> With the exception of patch construction and a few other routines
> described only in flowchart form, the variable names are constructed
> to follow a scheme and are perfectly understandable without looking at
> the spec.

assigning variable names begining from a and ending at z is also a scheme
and perfectly understandable they are surely not as i had to look every one
up in the spec during the review (lucky i had the spec), and often multiple
times as i forgot what k[2] and m[3] and all these 1 and 2 letter variables
meant
the code as it is is some of the messiest code we have in svn.
you surely can pretend its not so and claim that these variable "names"
are understandable without the spec but you just make yourself look
ridicolous with that. k and m are random letters and not appropriate
as anything but local variables and even this would be debateable.
but noone will know what k[0] k[2] m[0] and all these are without
the spec and without reverse engeneering it from the code.


> 
> I challenge you to try to do you H.264 refactoring in an soc style
> topic branch in SVN for two months... If you aren't too busy trying to
> find fonts less readable than the ones you use now.

iam using courier new in kwrite which is quite nice except the l/1 issue
suggestions for some other font are welcome, but most other monospaced
fonts ive seen dont look that good.



> 
> Suggesting our students use svn *in the manner svn has historically
> been used by our SoC projects* is one of the biggest disservices we
> can provide to them.

can you elaborate on the problem (preferably with text written in a
understandable scheme?) something like
m[0] k[1] a_b[5] cc d_e xx fq sb usb asb
maybe? or you could use numbers refering to page and line in a dictionary
instead of words. Just make sure you dont tell me what you mean by
"*in the manner svn has historically been used by our SoC projects*"

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Incandescent light bulbs waste a lot of energy as heat so the EU forbids them.
Their replacement, compact fluorescent lamps, much more expensive, dont fit in
many old lamps, flicker, contain toxic mercury, produce a fraction of the light
that is claimed and in a unnatural spectrum rendering colors different than
in natural light. Ah and we now need to turn the heaters up more in winter to
compensate the lower wasted heat. Who wins? Not the environment, thats for sure
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100315/6f540fb5/attachment.pgp>